You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In regards to a comment here just questioning usage of JSDOM
Details
Will make an issue for it specifically, but have been wondering if there's a way we can remove our dependency on JSDOM? In particular in browser.js it seems clunky to get the content from puppeteer (a real browser) but then just pass it back into a "fake" browser.
constbrowser=awaitpuppeteer.launch({headless: true,args: ['--no-sandbox']});constrenderer=newRenderer(browser);constresult=awaitrenderer.serialize(url);// need url: https://github.com/jsdom/jsdom/issues/2005constdom=newJSDOM(result.content,{ url });consthtml=dom.serialize();consttarget=path.join(outputDirectory,route);
I could see how JSDOM could be helpful for unit testing, so maybe we just need to make it a devDependency or just get some sort of simple DOM parsing library? Just seems like a lot to have both Puppeteer and JSDOM.
The text was updated successfully, but these errors were encountered:
Type of Change
Summary
In regards to a comment here just questioning usage of
JSDOM
Details
Will make an issue for it specifically, but have been wondering if there's a way we can remove our dependency on JSDOM? In particular in browser.js it seems clunky to get the content from puppeteer (a real browser) but then just pass it back into a "fake" browser.
I could see how JSDOM could be helpful for unit testing, so maybe we just need to make it a devDependency or just get some sort of simple DOM parsing library? Just seems like a lot to have both Puppeteer and JSDOM.
The text was updated successfully, but these errors were encountered: