Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bundling for CSS relative node_modules based url references breaks #1368

Open
thescientist13 opened this issue Dec 28, 2024 · 0 comments · May be fixed by #1369
Open

bundling for CSS relative node_modules based url references breaks #1368

thescientist13 opened this issue Dec 28, 2024 · 0 comments · May be fixed by #1369
Assignees
Labels
alpha.3 bug Something isn't working CLI v0.31.0
Milestone

Comments

@thescientist13
Copy link
Member

thescientist13 commented Dec 28, 2024

Type of Change

Bug

Summary

Looks like "self managed" relative references to node_modules will produce a 500 error in the console because it looks like an extra /node_modules/{specifier}/ is being prepended to the link.

@font-face {
  font-family: "Geist-Sans";
  src: url("../../node_modules/geist/dist/fonts/geist-sans/Geist-Regular.woff2") format("truetype");
}

@font-face {
  font-family: "Geist-Mono";
  src: url("../../node_modules/geist/dist/fonts/geist-mono/GeistMono-Regular.woff2")
    format("truetype");
}

@font-face {
  font-family: "Geist-Sans Bold";
  src: url("../../node_modules/geist/dist/fonts/geist-sans/Geist-Bold.woff2") format("truetype");
}

Screenshot 2024-12-28 at 12 14 44 PM
Screenshot 2024-12-28 at 12 17 33 PM

Details

Seems to be a regression / oversight from #1346 . See this PR for reference - ProjectEvergreen/www.greenwoodjs.dev#146

@thescientist13 thescientist13 added bug Something isn't working CLI alpha.3 v0.31.0 labels Dec 28, 2024
@thescientist13 thescientist13 added this to the 1.0 milestone Dec 28, 2024
@thescientist13 thescientist13 self-assigned this Dec 28, 2024
@thescientist13 thescientist13 changed the title relative node_modules references for CSS url bundling not working bundling for CSS relative node_modules based url references breaks Dec 28, 2024
@thescientist13 thescientist13 moved this from 🔖 Ready to 🏗 In progress in [Greenwood] Phase 10 - Ecosystem Compat Dec 28, 2024
@thescientist13 thescientist13 moved this from 🏗 In progress to 👀 In review in [Greenwood] Phase 10 - Ecosystem Compat Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha.3 bug Something isn't working CLI v0.31.0
Projects
Status: 👀 In review
1 participant