Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bun runtime support #1323

Open
thescientist13 opened this issue Nov 17, 2024 · 3 comments · May be fixed by #1308
Open

Bun runtime support #1323

thescientist13 opened this issue Nov 17, 2024 · 3 comments · May be fixed by #1308
Assignees
@thescientist13
Labels
CLI documentation Greenwood specific docs feature New feature or request needs upstream v0.32.0
Milestone
1.0

Comments

@thescientist13
Copy link
Member

Type of Change

Feature

Summary

Splitting of from #953 and based on some initial prototyping being conducted here, it seems like there is a very happy path towards basic Bun support for Greenwood.

What does that mean in practice? Effectively instead of using npm and node, levarge the equivalents in Bun

$ bun install
$ bun dev # maps to `greenwood develop`

Details

Some of the main considerations to account for as part of this work

  1. Support custom imports - https://bun.sh/docs/runtime/plugins (align with migrate to register function for NodeJS custom imports (no more flag?) #1220)
  2. Include a GitHub action to validate all test cases during Greenwood CI
  3. Add documentation to the Greenwood website
@thescientist13 thescientist13 added documentation Greenwood specific docs CLI feature New feature or request labels Nov 17, 2024
@thescientist13 thescientist13 added this to the 1.0 milestone Nov 17, 2024
@thescientist13 thescientist13 self-assigned this Nov 17, 2024
@thescientist13 thescientist13 linked a pull request Nov 28, 2024 that will close this issue
feature/issue 1323 support for Bun #1308
Draft
11 tasks
@thescientist13 thescientist13 linked a pull request Nov 28, 2024 that will close this issue
Draft
11 tasks
@thescientist13
Copy link
Member Author

Making good progress here!
https://github.com/thescientist13/greenwood-bun

@thescientist13 thescientist13 mentioned this issue Feb 10, 2025
Open
34 tasks
@thescientist13
Copy link
Member Author

Bun

Did a little testing with Bun 1.0. Got an error related to importing htmlparser

116 | async function trackResourcesForRoute(html, compilation, route) {
117 |   const { context } = compilation;
118 |   const root = htmlparser.parse(html, {
                   ^
TypeError: htmlparser.parse is not a function. (In 'htmlparser.parse(html, {
    script: !0,
    style: !0
  })', 'htmlparser.parse' is undefined)
      at /Users/owenbuckley/Workspace/project-evergreen/greenwood/packages/cli/src/lib/resource-utils.js:118:15
      at trackResourcesForRoute (/Users/owenbuckley/Workspace/project-evergreen/greenwood/packages/cli/src/lib/resource-utils.js:116:38)
      at /Users/owenbuckley/Workspace/project-evergreen/greenwood/packages/cli/src/lifecycles/prerender.js:121:10
      at /Users/owenbuckley/Workspace/project-evergreen/greenwood/packages/cli/src/lifecycles/prerender.js:107:37
      at /Users/owenbuckley/Workspace/project-evergreen/greenwood/packages/plugin-renderer-puppeteer/src/puppeteer-handler.js:19:18
      at /Users/owenbuckley/Workspace/project-evergreen/greenwood/packages/plugin-renderer-puppeteer/src/puppeteer-handler.js:13:23
      at processTicksAndRejections (:1:2602)

Made this change to the import and confirmed it worked in both Bun and Node and so was than able to succesfully build!

// before
import htmlparser from 'node-html-parser';

// after
import * as htmlparser from 'node-html-parser';

However, it looks like the serve and develop commands work, but just show a white page 🤔
Screenshot 2023-09-11 at 8 44 47 PM

@thescientist13

This comment has been minimized.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thescientist13 thescientist13

Labels
CLI documentation Greenwood specific docs feature New feature or request needs upstream v0.32.0
Projects
[Greenwood] Phase 10 - Ecosystem Compat
Status: 🏗 In progress
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

feature/issue 1323 support for Bun ProjectEvergreen/greenwood
1 participant
@thescientist13