Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

livereload not reloading on SVG (image) file changes consistently #1263

Closed
thescientist13 opened this issue Aug 9, 2024 · 0 comments · Fixed by #1264
Closed

livereload not reloading on SVG (image) file changes consistently #1263

thescientist13 opened this issue Aug 9, 2024 · 0 comments · Fixed by #1264
Assignees
Labels
alpha.6 bug Something isn't working CLI v0.30.0
Milestone

Comments

@thescientist13
Copy link
Member

thescientist13 commented Aug 9, 2024

Summary

Although it doesn't seem to be an issue in greenwood's repo (though that one is referenced in an <img> tag), in the new website repo I noticed that editing .svg files was not triggering live reload. A hard reload does work, fwiw

svg-live-reload-not-working.mov

Details

Not sure why? 🤔

Additionally, noticed that the logging line stating the livereload server has started is in the wrong place. It should be a callback to createServer, not watch

// wrong
liveReloadServer.watch(userWorkspace.pathname, () => {
  console.info(`Now watching directory "${userWorkspace}" for changes.`);
  return Promise.resolve(true);
});

// right
const liveReloadServer = livereload.createServer({
  // options
}, () => {
  console.info(`Now watching workspace directory for changes...`);
});
@thescientist13 thescientist13 added bug Something isn't working CLI alpha.6 v0.30.0 labels Aug 9, 2024
@thescientist13 thescientist13 added this to the 1.0 milestone Aug 9, 2024
@thescientist13 thescientist13 self-assigned this Aug 9, 2024
@thescientist13 thescientist13 changed the title livereload not reloading on SVG (image) files consistently livereload not reloading on SVG (image) file changes consistently Aug 9, 2024
@thescientist13 thescientist13 moved this from 🏗 In progress to 👀 In review in [Greenwood] Phase 9 - Standards and Conventions Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha.6 bug Something isn't working CLI v0.30.0
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant