Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

align static server port being hardcoded for generic URL creation #1096

Closed
thescientist13 opened this issue Apr 15, 2023 · 0 comments · Fixed by #1097
Closed

align static server port being hardcoded for generic URL creation #1096

thescientist13 opened this issue Apr 15, 2023 · 0 comments · Fixed by #1097
Assignees
@thescientist13
Labels
bug Something isn't working CLI v0.28.1
Milestone
1.0

Comments

@thescientist13
Copy link
Member

thescientist13 commented Apr 15, 2023 •
edited
Loading

Type of Change

Bug

Summary

Similar to #1092, realized now the port for getStaticServer is also hardcoded when creating a new instance for URL.

const url = new URL(`http://localhost:8080${ctx.url}`);

Details

This isn't really a bug per se as we aren't actually using this URL to make HTTP requests with, but it should at least be consistent with the actual state of the system.
@thescientist13 thescientist13 added bug Something isn't working CLI labels Apr 15, 2023
@thescientist13 thescientist13 added this to the 1.0 milestone Apr 15, 2023
@thescientist13 thescientist13 self-assigned this Apr 15, 2023
@thescientist13 thescientist13 changed the title static server port is hardcoded to 8080 static server port is hardcoded to 8080 for generic URL construction Apr 15, 2023
@thescientist13 thescientist13 changed the title static server port is hardcoded to 8080 for generic URL construction align static server port is hardcoded for generic URL creation Apr 15, 2023
@thescientist13 thescientist13 mentioned this issue Apr 15, 2023
Merged
@thescientist13 thescientist13 moved this from 🏗 In progress to 👀 In review in [Greenwood] Phase 9 - Standards and Conventions Apr 15, 2023
@thescientist13 thescientist13 changed the title align static server port is hardcoded for generic URL creation align static server port being hardcoded for generic URL creation Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thescientist13 thescientist13

Labels
bug Something isn't working CLI v0.28.1
Projects
No open projects
[Greenwood] Phase 9 - Standards and Conventions
Status: ✅ Done
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

use config port when creating URL hostnames in static server ProjectEvergreen/greenwood
1 participant
@thescientist13