Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

static router not working on Chrome / Edge browsers (anymore) #1068

Closed
thescientist13 opened this issue Feb 16, 2023 · 1 comment · Fixed by #1069
Closed

static router not working on Chrome / Edge browsers (anymore) #1068

thescientist13 opened this issue Feb 16, 2023 · 1 comment · Fixed by #1069
Assignees
Labels
bug Something isn't working CLI Router v0.27.4
Milestone

Comments

@thescientist13
Copy link
Member

thescientist13 commented Feb 16, 2023

Type of Change

Bug

Summary

Meant to open this a little while ago, but it seems as of the latest version of Chrome (109) the technique we use for Chromium browser based event delegation isn't working anymore.

For example, if you go to the About page, and then go the Docs page, you can see the docs site is doing a full page reload.
Screen Shot 2023-02-15 at 9 24 27 PM
Screen Shot 2023-02-15 at 9 24 17 PM

Still working in Firefox though! 😅 🦊

Details

So doing some logging in the browser, I am definitely not seeing path in the logged event object, so that obviously explains why its not working anymore.
Screen Shot 2023-02-15 at 6 38 47 PM

I suppose this puts Chrome in the same situation as Safari now without access to path or originalTarget` (Firefox) so not sure if this means we have to figure out #559 right now then?

Will see if there is a quick win here though, or maybe a slight tweak to our event delegation implementation?

I suppose this is worth a shout to anyone reading this who might be interested in helping with #560 🙏

@thescientist13 thescientist13 added bug Something isn't working CLI Router labels Feb 16, 2023
@thescientist13 thescientist13 added this to the 1.0 milestone Feb 16, 2023
@thescientist13 thescientist13 changed the title static router not working on Chrome (anymore) static router not working on Chrome / Edge browsers (anymore) Feb 16, 2023
@thescientist13
Copy link
Member Author

This StackOverflow thread covers the exact issue in question I think, with some of the comments to the top level reply calling out similar techniques in our current router implementation.

I suppose this may just be an issue with closed shadow roots in general maybe? It seems a lot to open all ShadowRoots just for classic event delegation? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLI Router v0.27.4
Projects
No open projects
1 participant