Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<style> tags in the <body> are not getting optimized #1022

Closed
thescientist13 opened this issue Dec 6, 2022 · 0 comments · Fixed by #1024
Closed

<style> tags in the <body> are not getting optimized #1022

thescientist13 opened this issue Dec 6, 2022 · 0 comments · Fixed by #1024
Assignees
@thescientist13
Labels
bug Something isn't working CLI v0.27.1
Milestone
1.0

Comments

@thescientist13
Copy link
Member

thescientist13 commented Dec 6, 2022 •
edited
Loading

Contrary to #581, it looks like a <style> in the <body> are not getting optimized.

For example

<body>
  <style>
    * {
      color: red;
      font-size: blue;
    }
  </style>
</body>

Comes out without any minification applied
Image

Answer is pretty simple actually, it was never enabled. 🤦

Could have sworn I had a test for this, so will definitely want to write one now. 😬
@thescientist13 thescientist13 converted this from a draft issue Dec 6, 2022
@thescientist13 thescientist13 added bug Something isn't working CLI labels Dec 6, 2022
@thescientist13 thescientist13 added this to the 1.0 milestone Dec 6, 2022
@thescientist13 thescientist13 self-assigned this Dec 6, 2022
@thescientist13 thescientist13 moved this from 🔖 Ready to 🏗 In progress in [Greenwood] Phase 9 - Standards and Conventions Dec 6, 2022
@thescientist13 thescientist13 mentioned this issue Dec 6, 2022
Merged
@thescientist13 thescientist13 moved this from 🏗 In progress to 👀 In review in [Greenwood] Phase 9 - Standards and Conventions Dec 6, 2022
Repository owner moved this from 👀 In review to ✅ Done in [Greenwood] Phase 9 - Standards and Conventions Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thescientist13 thescientist13

Labels
bug Something isn't working CLI v0.27.1
Projects
No open projects
[Greenwood] Phase 9 - Standards and Conventions
Status: ✅ Done
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Bug/issue 1022 style tags in body not optimizing ProjectEvergreen/greenwood
1 participant
@thescientist13