Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancment/issue 881 update for content over configuration #59

Closed
wants to merge 7 commits into from
Closed

Enhancment/issue 881 update for content over configuration #59

wants to merge 7 commits into from

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Feb 19, 2022 •
edited
Loading

Summary

As part of ProjectEvergreen/greenwood#881, migrating the Getting Started repo to also favor content over configuration

  1. Move <meta> and <title> out of greenwood.config.js into a new template/app.html
  2. Refactored current page templates to move common code into app.html
  3. Moved favicon.ico to root of workspace

TODOs

  1. Need to make sure Getting Started guide is updated accordingly
  2. Need v0.24.0 of Greenwood released when Enhancement/issue 881 favor content over configuration eg meta greenwood#892 is merged

@thescientist13 thescientist13 added the enhancement New feature or request label Feb 19, 2022
@thescientist13 thescientist13 self-assigned this Feb 19, 2022
@thescientist13 thescientist13 mentioned this pull request Feb 19, 2022
Merged
6 tasks
@thescientist13
Copy link
Member Author

already did this in #60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thescientist13 thescientist13

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thescientist13