Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Center the "all projects" button on the homepage (some devices) #263

Open
colleenskemp opened this issue Nov 7, 2021 · 3 comments
Open
Assignees
Labels
bug Something isn't working Collaboratory Should Have

Comments

@colleenskemp
Copy link
Collaborator

colleenskemp commented Nov 7, 2021

This is only for some devices. The below screenshot was captured from Chad's Google pixel 5A. Chrome

Screenshot_20211103-082003

@colleenskemp colleenskemp assigned brodavi and unassigned shrutimehta13 Nov 7, 2021
@colleenskemp colleenskemp added the bug Something isn't working label Nov 7, 2021
@colleenskemp colleenskemp changed the title Center the "all projects" button on the homepage Center the "all projects" button on the homepage (some devices) Nov 7, 2021
@shrutimehta13
Copy link
Collaborator

happening on iPhone 6/7/8 plus, nexus 6,6p, (approx 414px wide)
Tabs like Nexus 7 (600px wide)

ok on iPhone 6/7/8 (375 px wide), Ipad, Ipad Pro (768px wide)

@brodavi
Copy link
Collaborator

brodavi commented Nov 11, 2021

@colleenskemp I'm not recently experienced with this section of the code (the grid). I am sure I could figure out a way to fix it, but it would be pretty involved. Perhaps @sutjin since you worked on this most recently, can you think of a quick fix? I would probably not use grid here if it were me, so I'd end up doing a re-implementation, but if you're still familiar enough with this chunk of code to do a quick tweak to center the button on all devices, I think that'd probably be a better use of time.

@brodavi brodavi assigned sutjin and colleenskemp and unassigned brodavi Nov 11, 2021
@colleenskemp colleenskemp assigned brodavi and unassigned sutjin Nov 15, 2021
@colleenskemp
Copy link
Collaborator Author

Let's cap this at 3 hours - passing to @sutjin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Collaboratory Should Have
Projects
None yet
Development

No branches or pull requests

4 participants