Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with footer spacing- project listing page #251

Open
colleenskemp opened this issue Nov 4, 2021 · 5 comments
Open

Issue with footer spacing- project listing page #251

colleenskemp opened this issue Nov 4, 2021 · 5 comments

Comments

@colleenskemp
Copy link
Collaborator

colleenskemp commented Nov 4, 2021

Design fix
There is an unwanted space on the left side of footer on project listing page.

Screen Shot 2021-11-07 at 11 06 20 AM

Please make footer consistent with the homepage - fullscreen (within a page container).

Screen Shot 2021-11-07 at 11 05 24 AM

@colleenskemp colleenskemp assigned brodavi and litenull and unassigned litenull and brodavi Nov 7, 2021
@colleenskemp colleenskemp changed the title Issue with footer - project listing page Issue with footer spacing- project listing page Nov 7, 2021
@colleenskemp colleenskemp assigned brodavi and unassigned litenull Nov 9, 2021
@brodavi
Copy link
Collaborator

brodavi commented Nov 11, 2021

The problem here is that every container has a max width. We would either have to remove the max width for all the containers, or put the footer outside the container. I'm not sure what we should do here, but I don't think this will be a trivial change @colleenskemp

@brodavi brodavi assigned colleenskemp and unassigned brodavi Nov 11, 2021
@colleenskemp
Copy link
Collaborator Author

@litenull - This is unresolved. Still seeing that funny space. Sending this back to you.

@litenull
Copy link
Collaborator

@colleenskemp - Is this cache maybe ? The footer should be centered - spaces on both sides.

@colleenskemp
Copy link
Collaborator Author

@litenull - After clearing cache, I can still see the white space on the left of the footer. Same when viewed in incognito. I see this issue when viewed in Firefox and Chrome. There should be white space on either side according to the design.

@litenull
Copy link
Collaborator

@colleenskemp Which URL are you using?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants