Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workbook view/edit not scrollable to view/select all sectors & clusters #133

Open
shrutimehta13 opened this issue Nov 22, 2021 · 10 comments
Assignees
Labels

Comments

@shrutimehta13
Copy link

  1. Create a New workbook
  2. Observe Portfolio selection > page is scrollable and all visible

Screenshot 2021-11-22 at 6 37 44 PM

3. Save selection 4. now observe workbook page or choose to ediT

Observed:
No scrollbar
Screenshot 2021-11-22 at 6 37 00 PM

@shrutimehta13
Copy link
Author

shrutimehta13 commented Nov 22, 2021

related to ProjectDrawdown/open-collaboratory#123

@colleenskemp
Copy link
Collaborator

colleenskemp commented Nov 22, 2021

@shrutimehta13 - I've walked through this and see that only the selected solutions are shown after save. This is expected and confirmed in the designs. https://www.figma.com/file/QImAyi1guE4AICGMN7uODK/Drawdown-Portfolio-UI---%5BFigma-Chakra-UI%5D?node-id=1971%3A122156

If I understood your feedback correctly, will you please close this ticket?

If I didn't fully understand the issue described, please let me know. Thank you!

@eethann
Copy link
Collaborator

eethann commented Nov 23, 2021

I believe this ticket should be in the Global Research Platform project and not the Open Collaboratory project

@eethann eethann transferred this issue from ProjectDrawdown/research-platform Nov 23, 2021
@eethann
Copy link
Collaborator

eethann commented Nov 23, 2021

Confirmed that this is an error.

@eethann eethann assigned litenull and unassigned shrutimehta13 Nov 23, 2021
@shrutimehta13
Copy link
Author

@colleenskemp issue is after saving a workbook, we are not able to add/remove solutions as the page is not scrollable and hence not selectable by user. This is a Must Fix.

@colleenskemp colleenskemp assigned colleenskemp and unassigned litenull Dec 6, 2021
@colleenskemp
Copy link
Collaborator

Okay - I think this was a regression. @sutjin - will you please take a look?

@shrutimehta13
Copy link
Author

tested here https://stage.pdd.colab.coop/ [Edit portfolio] with existing and new workbooks and it does not work still.

@sutjin
Copy link
Collaborator

sutjin commented Dec 20, 2021

weird, let me try to redeploy and see what's going on

@sutjin sutjin assigned colleenskemp and shrutimehta13 and unassigned sutjin Dec 20, 2021
@sutjin
Copy link
Collaborator

sutjin commented Dec 20, 2021

redeploying seems to fixed it, please double check :)

@shrutimehta13
Copy link
Author

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants