Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duration of Lifetime Savings graph does not match period of study #132

Open
eethann opened this issue Nov 23, 2021 · 3 comments · Fixed by #134
Open

Duration of Lifetime Savings graph does not match period of study #132

eethann opened this issue Nov 23, 2021 · 3 comments · Fixed by #134
Assignees
@colleenskemp
Labels
Health & Education UI

Comments

@eethann
Copy link
Collaborator

eethann commented Nov 23, 2021

See #123 for more information. The Lifetime Savings graph is showing many years past the end of the study, so is declining when it should not.
@eethann
Copy link
Collaborator Author

eethann commented Nov 23, 2021

@eethann
Copy link
Collaborator Author

eethann commented Nov 23, 2021

This one is a must fix.

@eethann eethann mentioned this issue Nov 23, 2021
Closed
@sutjin sutjin linked a pull request Dec 6, 2021 that will close this issue
introduce data filtering #134
Merged
@colleenskemp colleenskemp assigned shrutimehta13 and unassigned sutjin Dec 6, 2021
@colleenskemp colleenskemp reopened this Dec 6, 2021
@shrutimehta13
Copy link

shrutimehta13 commented Dec 7, 2021 •
edited
Loading

year period corrected in lifetime graph.

here /technologies/concentratedsolar showing Nan and declining graph @eethann that could be a separate issue

Screenshot 2021-12-07 at 5 29 59 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colleenskemp colleenskemp

Labels
Health & Education UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

introduce data filtering ProjectDrawdown/global-research-platform
4 participants
@eethann @sutjin @colleenskemp @shrutimehta13