Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor error with placement of route steps #255

Merged
merged 9 commits into from
Dec 1, 2019

Conversation

Pilot-Marc
Copy link
Collaborator

Background

The pivot point for each route step is 0.5 of the distance, and there's a comment that 0.5 is sometimes off and that the constant should be a settable property. The real fix should be to set the step location to the center of the line, which would coincide with the node's default pivot point.

Note: This resolves issue #245

Breaking Changes

N/A

Meta

  • Tied to Version Release(s): N/A

PR Checklist

  • CI runs clean?
  • Appropriate label has been added to this PR (i.e., Bug, Enhancement, etc.).
  • Documentation has been added to all open, and public scoped methods and properties.
  • Changelog has been updated
  • Tests have have been added to all new features. (not a requirement, but helpful)
  • Image/GIFs have been added for all UI related changed.

Screenshots

@halmueller halmueller merged commit 1a728b5 into AndrewHartAR:develop Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants