Improve geodesy calculations and test coverage. #244
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The underlying formula in
coordinateWithBearing(bearing:distanceMeters:)
used incorrect logic for determining the radius of the earth at the given latitude, so that function returned slightly incorrect results. This PR addresses that error, and adds unit test coverage for that function and its supporting functions.I believe that the implementations of
translatedLocation(with:)
andtranslation()
are still not quite right. I've added the most basic test coverage possible, with an enormous accuracy bound, but these two functions need some analysis. I'll open a separate issue for that, but will move on for the time being, since they seem to work ok in the field.Resolves issue #239 (the accuracy part, not the Google Maps suggestion).
Breaking Changes
Any use of
coordinateWithBearing(bearing:distanceMeters:)
, or oftranslatedLocation(with:)
, will see slightly different results.Meta
PR Checklist
open
, andpublic
scoped methods and properties.