From 7c7dd26045d802c560505e7501124ffe09982251 Mon Sep 17 00:00:00 2001 From: SeoYeon Min <126096318+gitseoyeon@users.noreply.github.com> Date: Thu, 7 Nov 2024 16:41:46 +0900 Subject: [PATCH] =?UTF-8?q?Refactor:=20=EC=98=88=EC=95=BD=20=EB=AA=A9?= =?UTF-8?q?=EB=A1=9D=20=EC=A1=B0=ED=9A=8C=EC=8B=9C=20=EA=B4=80=EB=A6=AC?= =?UTF-8?q?=EC=9E=90=20=EC=A1=B0=ED=9A=8C=20=EC=B0=A8=EB=B3=84=ED=99=94=20?= =?UTF-8?q?(#298)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Refactor: getGroupReservation 메소드 수정 * Chore: 도커 빌드 명령 수정 --- .github/workflows/gradle.yml | 2 +- .../service/booth/BoothReservationService.java | 18 +++++++++++++++--- 2 files changed, 16 insertions(+), 4 deletions(-) diff --git a/.github/workflows/gradle.yml b/.github/workflows/gradle.yml index 0638320c..379e988f 100644 --- a/.github/workflows/gradle.yml +++ b/.github/workflows/gradle.yml @@ -47,7 +47,7 @@ jobs: run: test -f ./src/main/resources/application.properties && echo "File exists" || echo "File does not exist" - name: docker image build - run: docker build -t ${{ secrets.DOCKER_USERNAME }}/openbook:latest . + run: docker build --build-arg DEPENDENCY=build/dependency -t ${{ secrets.DOCKER_USERNAME }}/openbook --platform linux/amd64 . - name: docker login uses: docker/login-action@v2 diff --git a/src/main/java/com/openbook/openbook/service/booth/BoothReservationService.java b/src/main/java/com/openbook/openbook/service/booth/BoothReservationService.java index 56173d5b..fc25d730 100644 --- a/src/main/java/com/openbook/openbook/service/booth/BoothReservationService.java +++ b/src/main/java/com/openbook/openbook/service/booth/BoothReservationService.java @@ -57,7 +57,7 @@ public List getReservationsByBooth(long boothId){ if(!booth.getStatus().equals(BoothStatus.APPROVE)){ throw new OpenBookException(ErrorCode.BOOTH_NOT_APPROVED); } - return getGroupReservation(boothId); + return getGroupReservation(boothId, false); } @Transactional @@ -66,10 +66,10 @@ public List getAllManageReservations(Long userId, Long boot if(!booth.getManager().getId().equals(userId)){ throw new OpenBookException(ErrorCode.FORBIDDEN_ACCESS); } - return getGroupReservation(boothId); + return getGroupReservation(boothId, true); } - private List getGroupReservation(Long boothId){ + private List getGroupReservation(Long boothId, boolean isAdmin) { List reservations = getBoothReservations(boothId); Map> groupedByName = reservations.stream() .collect(Collectors.groupingBy(BoothReservation::getName)); @@ -85,6 +85,18 @@ private List getGroupReservation(Long boothId){ List details = dateEntry.getValue().stream() .flatMap(reservation -> reservationDetailService .getReservationDetails(reservation.getId()).stream()) + .map(detail -> { + if (isAdmin) { + return detail; + } else { + return new BoothReservationDetailDto( + detail.id(), + detail.times(), + detail.status(), + null + ); + } + }) .collect(Collectors.toList()); return BoothReservationDateDto.of(date, details);