Russian arrive instructions update #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
reviewed
Mar 26, 2019
languages/translations/ru.json
Outdated
| "short-upcoming": "Вы скоро прибудете", | ||
| "upcoming": "Вы прибываете в {nth} пункт назначения, он будет слева", | ||
| "short": "Вы прибыли, слева", | ||
| "short-upcoming": "Вы скоро прибудете, слева", |
There was a problem hiding this comment.
@yuryleb, the short and short-upcoming messages are intended to omit information about the side of the street, because they’re meant to be announced as part of another instruction before the user gets to the destination. For example, a navigation application might combine this message like “In 500 feet, turn left at Main Street, then you will arrive”.
That said, these messages aren’t used in OSRMTI itself, so it’s up to the client to decide in what context to use them. Providing distinct upcoming and short-upcoming messages gives developers a choice of how verbose to be in a given situation.
There was a problem hiding this comment.
Thanks for clarification, fixed.
kevinkreiser
added a commit
that referenced
this pull request
Mar 29, 2019
- Added a Hungarian localization and grammar. [#274](#274) - Added a Japanese localization. [#277](#277) - Added an Arabic localization. [#267](#267) - Added a Slovenian localization. [#264](#264) - Updated Russian arrive instructions. [#278](#278) - Updated French grammar with 'chaussée' status street name and better articles matching. [#268](https://github.com/Project-OSRM/osrm-text-instructions/pull/268)[#279](https://github.com/Project-OSRM/osrm-text-instructions/pull/279)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Just a Russian arrive instructions update with more appropriate verbs term.
Tasklist