Standardize Spanish on informal imperative #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also updated remaining untranslated strings in the Spanish localizations.
1ec5
force-pushed
the
1ec5-tx-es-informal
branch
from
78e8b5a to
54e7ab0
Compare
6 tasks
danpaz
reviewed
Mar 23, 2018
languages/translations/es-ES.json
Outdated
| "name": "En la rotonda continúa recto por {way_name}", | ||
| "destination": "En la rotonda continúa recto hacia {destination}" | ||
| "default": "Continúe recto", | ||
| "name": "Continúa recto por {way_name}", |
There was a problem hiding this comment.
Mixed tenses here: Continúe Continúa - was there an issue with the find and replace?
There was a problem hiding this comment.
I did find-and-replace on the es localization but not the es-ES localization, which looked at a glance to already have been standardized. I’ll fix up the es-ES localization.
|
As a sanity check, I’ve verified that both Google Maps and Apple Maps use the informal imperative form across all the Spanish dialects you can choose from on iOS. |
danpaz
added a commit
that referenced
this pull request
Apr 11, 2018
- Added a European Portuguese localization. [#229](#229) - The Spanish localization now uses the informal imperative form instead of the formal imperative form, for consistency with the Castillian Spanish localization. [#230](#230) - Added some abbreviations in German, Hebrew, Hungarian, Slovenian, and Ukrainian. [#226](#226) - Added support for named waypoints in arrival instructions. [#235](#235)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Castilian Spanish localization consistently uses the informal imperative form, while the (Latin American) Spanish localization uses a mix of formal and informal imperative forms. This change standardizes both localizations on the informal imperative form for consistency. If there’s a need for giving turn instructions more formally, that could be a separate
es-formallocalization.Also updated remaining untranslated strings in both Spanish localizations.
Tasklist
/cc @danpaz @Guardiola31337 @Sealos