Add "exit {exit}" to phrases #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
reviewed
Feb 6, 2018
languages/translations/fr.json
Outdated
| @@ -41,6 +41,9 @@ | |||
| "ox": "Serrer à gauche", | |||
| "xox": "Rester au milieu", | |||
| "oxo": "Rester à gauche ou à droite" | |||
| }, | |||
| "vocabulary": { | |||
| "exit": "la sortie" | |||
There was a problem hiding this comment.
Is this term being used as part of an instruction or in a standalone context, such as in banner text in the navigation SDKs? This library already incorporates the words “the exit” into some instruction formats:
|
I have made these updates. |
added 2 commits
February 8, 2018 13:57
allierowan
changed the title
1ec5
reviewed
Feb 9, 2018
languages/translations/es.json
Outdated
| @@ -54,7 +54,8 @@ | |||
| "two linked by distance": "{instruction_one} y luego en {distance}, {instruction_two}", | |||
| "two linked": "{instruction_one} y luego {instruction_two}", | |||
| "one in distance": "A {distance}, {instruction_one}", | |||
| "name and ref": "{name} ({ref})" | |||
| "name and ref": "{name} ({ref})", | |||
| "exit with number": "la salida {exit}" | |||
There was a problem hiding this comment.
The article la should be omitted from this string. It wouldn’t appear in signage.
languages/translations/fr.json
Outdated
| @@ -54,7 +54,8 @@ | |||
| "two linked by distance": "{instruction_one}, puis, dans {distance}, {instruction_two}", | |||
| "two linked": "{instruction_one}, puis {instruction_two}", | |||
| "one in distance": "Dans {distance}, {instruction_one}", | |||
| "name and ref": "{name} ({ref})" | |||
| "name and ref": "{name} ({ref})", | |||
| "exit with number": "la sortie {exit}" | |||
There was a problem hiding this comment.
France accompanies exit numbers with the 
mcwhittemore
approved these changes
Feb 9, 2018
1ec5
approved these changes
Feb 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are hardcoding the word "exit" because we don't have a phrase for it here. I have added it to the
phrasessection.Tasklist
@mcwhittemore @lyzidiamond @1ec5 thoughts on this approach? Should I add this section to all languages with the english fallback?