Short arrival text #207
Merged
Short arrival text #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcwhittemore
approved these changes
Jan 12, 2018
| Object.keys(fixture.instructions).forEach((l) => { | ||
| // ignore custom instructions that don't get compiled | ||
| if (!fixture.step) return; |
There was a problem hiding this comment.
What does this solve?
There was a problem hiding this comment.
this code was trying to test the new fixtures I added, but they don't get compiled by default, you have to specifically grab them by the right path. The fixtures I created don't have steps connected to them, so I just added this line so they don't get included
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
We'd like a shorter arrival text option to save space- this adds a short option for both the upcoming and default arrival texts. For other languages, I copied over their regular default and upcoming phrases for now.
Tasklist