Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Turkish language #158

Merged
merged 5 commits into from
Sep 20, 2017
Merged

Added Turkish language #158

merged 5 commits into from
Sep 20, 2017

Conversation

farmsensor
Copy link
Contributor

Added Turkish language

yuryleb
yuryleb suggested changes Sep 17, 2017
View reviewed changes
languages.js Outdated
@@ -12,6 +12,7 @@ var instructionsPtBr = require('./languages/translations/pt-BR.json');
var instructionsRo = require('./languages/translations/ro.json');
var instructionsRu = require('./languages/translations/ru.json');
var instructionsSv = require('./languages/translations/sv.json');
var instructionsSv = require('./languages/translations/tr.json');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You overwrite Sweden language file with yours. You should take another various name, say instructionsTr

yuryleb
yuryleb reviewed Sep 17, 2017
View reviewed changes
Copy link
Contributor

@yuryleb yuryleb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, now your code looks correct.
But you also forgot to extend test fixtures with UPDATE=1 npm test and them too.

1ec5
1ec5 approved these changes Sep 19, 2017
View reviewed changes
Copy link
Member

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, @malte777! I ran UPDATE=1 npm test and pushed the results to your branch. Once you take a look at the test fixtures to ensure that the generated strings match your expectations?

@farmsensor
Copy link
Contributor Author

@1ec5 Thanks for UPDATE=1 npm test. I looked at the test fixtures, everything is fine.

@1ec5 1ec5 merged commit 51bc415 into Project-OSRM:master Sep 20, 2017
@1ec5 1ec5 mentioned this pull request Sep 23, 2017
Merged
1ec5 added a commit that referenced this pull request Sep 26, 2017
@1ec5
v0.7.1
badb219 
- Added Castilian Spanish localization. #163
- Added Esperanto localization. #162
- Added Romanian localization. #105
- Added Turkish localization. #158
- Added a `language` argument to `capitalizeFirstLetter`, which capitalizes according to that language’s rules. #164
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuryleb yuryleb yuryleb approved these changes

@1ec5 1ec5 1ec5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@farmsensor @1ec5 @yuryleb