Italian, Brazilian Portuguese, Ukrainian #137

1ec5 · 2017-08-22T20:38:20Z

Added Italian, Brazilian Portuguese, and Ukrainian localizations from Transifex. Also updated Russian, Spanish, ~~Swedish~~, and Vietnamese, which have complete localizations. I avoided bringing in updates to the other localizations, since there are some key untranslated strings around exits. I also omitted Romanian, which is the subject of #105.

@nicomazz @leonardortlima @Andygol @oxidase, would you mind reviewing the test fixtures to ensure that the generated strings line up with your expectations? Thank you!

/cc @bsudekum

yuryleb · 2017-08-22T21:03:05Z

languages/translations/ru.json

@@ -238,37 +243,51 @@
            "default": {
                "default": "Сверните на съезд",
                "name": "Сверните на съезд на {way_name}",
-                "destination": "Сверните на съезд в направлении {destination}"
+                "destination": "Сверните на съезд в направлении {destination}",
+                "exit": "Сверните на съезд {exit} ",


Extra trailing whitespace - I hope this is not a problem?

yuryleb · 2017-08-22T21:05:28Z

languages/translations/ru.json

            },
            "left": {
                "default": "Сверните на левый съезд",
                "name": "Сверните на левый съезд на {way_name}",
-                "destination": "Сверните на правый съезд в направлении {destination}"
+                "destination": "Сверните на правый съезд в направлении {destination}",


But here is "right exit" instead of "left". I should update translation :(

yuryleb · 2017-08-22T21:27:43Z

languages/translations/ru.json

            },
            "sharp left": {
                "default": "Поверните на левый съезд",
                "name": "Поверните на левый съезд на {way_name}",
-                "destination": "Поверните на левый съезд в направлении {destination}"
+                "destination": "Поверните на левый съезд в направлении {destination}",
+                "exit": "Сверните на съезд {exit} слева",


Different verbs from this line and below, they also should be updated

yuryleb · 2017-08-22T21:30:23Z

I reviewed Russian translation and updated it more once on Transifex - there were some quite critical style mistakes, sorry 😞

nicomazz · 2017-08-22T22:21:08Z

test/fixtures/v5/continue/sharp_left_default.json

@@ -12,10 +12,13 @@
        "es": "Continua cerrada a la izquierda",
        "fr": "Continuer franchement à gauche",
        "id": "Terus tajam kiri",
+        "it": "Continua Leggera svolta a sinistra",


There are problems with the Italian translation of "sharp ...", which does not sound very good at this time.
Could I have a (street?) example where this instruction should be used?

I think a sharp left would always be given as a turn instruction rather than a continue instruction, so it might be safe to ignore the weird output here. Is that correct @bsudekum?

I think the terms "sharp" and "slight" could ignore in Italian, translating "sharp right" into only "right". Is this a good solution? Otherwise there would be many problems..

nicomazz · 2017-08-22T22:27:29Z

test/fixtures/v5/end_of_road/sharp_left_default.json

@@ -12,10 +12,13 @@
        "es": "Gire a cerrada a la izquierda",
        "fr": "Tourner franchement à gauche",
        "id": "Belok tajam kiri",
+        "it": "Gira a Leggera svolta a sinistra",


This doesn't sound good. At present I do not know how to translate it better. I'll think about it.

If it isn’t possible to translate the component strings in a way that would make sense, it’s also possible to override this particular configuration using an override file. Let me know what the string should be, and I can add the override file as part of this PR.

I've made some changes in transifex. Maybe I've resolved the problem

nicomazz · 2017-08-22T22:42:27Z

test/fixtures/v5/fork/straight_default.json

@@ -12,10 +12,13 @@
        "es": "Mantengase recto en el cruce",
        "fr": "Rester tout droit à l'embranchement",
        "id": "Tetap lurus di pertigaan",
+        "it": "Mantieni la Continua dritto al bivio",


There is a problem with italian.
With left or right modifier "keep {modifier} at the fork" it's ok.
With "straight" modifier the phrase should be like "{modifier} at the fork" and not "Keep {modifier} at the fork" (translated in italian: "Continua dritto al bivio", without the initial "keep")

This is also awkward in English: “Keep straight at the fork”. However, I think it’s unlikely that the Directions API would ever output this instruction. I think the API would omit the instruction entirely, unless the destination street has a different name, in which there would be a continue instruction. @bsudekum, is that correct?

nicomazz · 2017-08-22T22:45:22Z

test/fixtures/v5/merge/straight_destination.json

@@ -13,10 +13,13 @@
        "es": "Gire a recto hacia Destination 1",
        "fr": "Rejoindre tout droit en direction de Destination 1",
        "id": "Bergabung lurus menuju Destination 1",
+        "it": "Immettiti Continua dritto verso Destination 1",


Same problem here with "straight" modifier

Andygol · 2017-08-23T09:35:55Z

languages/translations/uk.json

+                "destination": "Здійсніть розворот у напрямку {destination}"
+            }
+        },
+        "off ramp": {


@oxidase Please take a look here.
It confuses me such we have equal translation for off ramp and on ramp further

@Andygol it looks like direct translation from English where no difference in on/off ramp instructions. what confuses me is ramp translation as естакада probably в'їзд / з'їзд is better

@oxidase yes, I agreed with you, that в'їзд / з'їзд is much better. May you make this changes right here on github? I don't have the right to edit here.

If any changes are needed, please make them in Transifex, and I’ll update this PR. Otherwise, if we make the changes directly in GitHub, they’ll get overridden the next time someone pulls translations from Transifex.

@1ec5 I updated Ukrainian translation on Transifex according to @oxidase suggestions

oxidase

🇺🇦 on transiflex LGTM

1ec5 · 2017-08-23T17:30:30Z

I completed a few remaining translations in Spanish and added it to this PR in 97c561e. (This PR still omits the 🇪🇸 Spanish localization that’s ongoing.) The biggest change is that the instructions use usted form instead of tuteo. @Guardiola31337, can you take a look at the updated Spanish strings? Thanks!

1ec5 · 2017-08-23T17:34:16Z

I also completed the German localization and added it in 97c561e – would appreciate a quick look-over from @daniel-j-h.

leonardortlima · 2017-08-23T18:05:14Z

I made a few more changes on transifex. I think Brazilian Portuguese is good to go now.

daniel-j-h

German translation has a small mistake, otherwise looks good

1ec5 · 2017-08-24T15:33:22Z

German issues fixed in 69290ed. There’s some ongoing discussion about Swedish in #136, but it sounds like this PR still represents an improvement over what’s in master.

/cc @frederoni

bsudekum

Code looks good

yuryleb · 2017-08-24T20:55:14Z

languages/translations/ru.json

-                "default": "Плавно сверните на левый съезд",
-                "name": "Плавно сверните на левый съезд на {way_name}",
-                "destination": "Плавно сверните на левый съезд в направлении {destination}"
+                "default": "Перестройтесь левее съезд",


Preposition is missing

yuryleb · 2017-08-24T20:57:35Z

Russian translation had one string with missing prepostion, Transifex was updated again.

Also updated Russian, Vietnamese.

1ec5 · 2017-08-25T17:01:26Z

I’ve removed Swedish from this PR, now that #138 has landed.

- Adds Brazilian Portuguese, Italian, and Ukrainian localizations. #137 - Adds the word “right” to right-hand exit instructions. #125 - Improves the wording of “continue straight” instructions. #130 - Improves the wording of various instructions in Russian and Swedish. #138 - The Spanish localization consistently uses usted form. #137

1ec5 added the enhancement label Aug 22, 2017

1ec5 self-assigned this Aug 22, 2017

1ec5 requested a review from bsudekum August 22, 2017 20:38

yuryleb reviewed Aug 22, 2017

View reviewed changes

nicomazz reviewed Aug 22, 2017

View reviewed changes

1ec5 force-pushed the 1ec5-tx-it-ptbr-uk branch from a42222e to c19fe98 Compare August 23, 2017 01:28

Andygol reviewed Aug 23, 2017

View reviewed changes

oxidase approved these changes Aug 23, 2017

View reviewed changes

1ec5 force-pushed the 1ec5-tx-it-ptbr-uk branch from 1bd9c77 to 97c561e Compare August 23, 2017 17:25

1ec5 requested a review from daniel-j-h August 23, 2017 17:34

1ec5 mentioned this pull request Aug 23, 2017

Improving Swedish translation (Exit numbers, overrides, modifiers and roundabouts and questions) #136

Closed

daniel-j-h requested changes Aug 24, 2017

View reviewed changes

1ec5 force-pushed the 1ec5-tx-it-ptbr-uk branch from 69290ed to caab30c Compare August 24, 2017 15:37

bsudekum approved these changes Aug 24, 2017

View reviewed changes

yuryleb reviewed Aug 24, 2017

View reviewed changes

daniel-j-h approved these changes Aug 25, 2017

View reviewed changes

1ec5 force-pushed the 1ec5-tx-it-ptbr-uk branch from c838d92 to c676e2a Compare August 25, 2017 16:58

1ec5 added 2 commits August 25, 2017 09:59

Added Italian, Brazilian Portuguese, Ukrainian

16f1d25

Also updated Russian, Vietnamese.

Updated Italian, Russian

9fc3c0a

1ec5 added 5 commits August 25, 2017 09:59

Updated Ukrainian

7df8513

Updated German, Spanish, Brazilian Portuguese, Ukrainian

6487703

Updated Italian

1eb28cb

Updated Brazilian Portuguese

3f4f911

Updated Russian

180c13a

1ec5 force-pushed the 1ec5-tx-it-ptbr-uk branch from c676e2a to 180c13a Compare August 25, 2017 17:00

1ec5 merged commit 0850d5d into master Aug 25, 2017

1ec5 deleted the 1ec5-tx-it-ptbr-uk branch August 25, 2017 17:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Italian, Brazilian Portuguese, Ukrainian #137

Italian, Brazilian Portuguese, Ukrainian #137

1ec5 commented Aug 22, 2017 •

edited

Loading

yuryleb Aug 22, 2017

yuryleb Aug 22, 2017

yuryleb Aug 22, 2017

yuryleb commented Aug 22, 2017

nicomazz Aug 22, 2017

1ec5 Aug 23, 2017

nicomazz Aug 23, 2017

nicomazz Aug 22, 2017

1ec5 Aug 23, 2017 •

edited

Loading

nicomazz Aug 23, 2017

nicomazz Aug 22, 2017

1ec5 Aug 23, 2017

nicomazz Aug 22, 2017

Andygol Aug 23, 2017

oxidase Aug 23, 2017

Andygol Aug 23, 2017

1ec5 Aug 23, 2017

Andygol Aug 23, 2017

oxidase left a comment

1ec5 commented Aug 23, 2017

1ec5 commented Aug 23, 2017

leonardortlima commented Aug 23, 2017

daniel-j-h left a comment

1ec5 commented Aug 24, 2017

bsudekum left a comment

yuryleb Aug 24, 2017

yuryleb commented Aug 24, 2017

1ec5 commented Aug 25, 2017

Italian, Brazilian Portuguese, Ukrainian #137

Italian, Brazilian Portuguese, Ukrainian #137

Conversation

1ec5 commented Aug 22, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yuryleb commented Aug 22, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

1ec5 Aug 23, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

oxidase left a comment

Choose a reason for hiding this comment

1ec5 commented Aug 23, 2017

1ec5 commented Aug 23, 2017

leonardortlima commented Aug 23, 2017

daniel-j-h left a comment

Choose a reason for hiding this comment

1ec5 commented Aug 24, 2017

bsudekum left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yuryleb commented Aug 24, 2017

1ec5 commented Aug 25, 2017

1ec5 commented Aug 22, 2017 •

edited

Loading

1ec5 Aug 23, 2017 •

edited

Loading