Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clang-tidy warnings #6928

Open
1 of 13 tasks
SiarheiFedartsou opened this issue Jun 6, 2024 · 1 comment
Open
1 of 13 tasks

Fix clang-tidy warnings #6928

SiarheiFedartsou opened this issue Jun 6, 2024 · 1 comment
Labels
CI

Comments

@SiarheiFedartsou
Copy link
Member

SiarheiFedartsou commented Jun 6, 2024 •
edited
Loading

We updated to clang-tidy 18 in https://github.com/Project-OSRM/osrm-backend/pull/6919/files and disabled some of newly introduced warnings. This issue is to track progress on fixing them:

  • bugprone-chained-comparison
  • bugprone-incorrect-enable-if
  • bugprone-switch-missing-default-case
  • bugprone-empty-catch
  • bugprone-unused-return-value
  • misc-include-cleaner
  • performance-noexcept-swap
  • performance-enum-size
  • performance-avoid-endl
  • readability-redundant-inline-specifier
  • readability-avoid-nested-conditional-operator
  • readability-avoid-return-with-void-value
  • readability-redundant-casting

NOTE: some of them may be not actually very useful
This was referenced Jun 6, 2024
Merged
Merged
@SiarheiFedartsou
Copy link
Member Author

#6934

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SiarheiFedartsou