Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DirectLoader mode to default Cucumber test suite #6661

Closed
mjjbell opened this issue Jul 26, 2023 · 0 comments · Fixed by #6664
Closed

Add DirectLoader mode to default Cucumber test suite #6661

mjjbell opened this issue Jul 26, 2023 · 0 comments · Fixed by #6664

Comments

@mjjbell
Copy link
Member

mjjbell commented Jul 26, 2023

Feature

Currently npm test runs the Cucumber suite with a matrix configuration for selecting the algorithm (CH, MLD) and data loading (shared-memory, mmap) options.

However, there is a third data loading option, 'direct load', which is to directly load the datasets into the osrm-routed process memory.

The code paths for each data loading option are distinct

It would be wise to include direct data loading as part of the Cucumber configuration matrix, even more so given I plan to make changes to support optional datasets.

To keep runtime down in CI, we could run direct loading on only a handful of jobs, or split the CI flow to run Cucumber tests as a parallel substep for each build configuration.

This will also help tidy up the handful of direct load tests that erroneously run in shared memory and mmap mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant