Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip_waypoints ignored in node bindings #6059

Closed
maciejb opened this issue Jun 22, 2021 · 0 comments · Fixed by #6060
Closed

skip_waypoints ignored in node bindings #6059

maciejb opened this issue Jun 22, 2021 · 0 comments · Fixed by #6060

Comments

@maciejb
Copy link
Contributor

maciejb commented Jun 22, 2021

I'm trying to implement skip_waypoints as an option my Node API, but the parameter has no effect. My C++ is beyond rusty, but I believe the issue is that include/nodejs/node_osrm_support.hpp does not include this in the argumentsToParameter function.

I'm happy to submit a pull request for this, essentially duplicating the "generate_hints" block from lines 662:676, replacing generate_hints with skip_waypoints. However, I lack the skills to determine if this is a sufficient fix. Can anyone provide guidance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant