Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSRM can't be compiled with GCC 10 #5858

Closed
akashihi opened this issue Oct 16, 2020 · 2 comments
Closed

OSRM can't be compiled with GCC 10 #5858

akashihi opened this issue Oct 16, 2020 · 2 comments

Comments

@akashihi
Copy link
Contributor

Outdated Sol2 library prevents OSRM compilation with gcc 10:

osrm-backend/third_party/sol2/sol2/sol.hpp:6919:40: error: call of overloaded ‘push<const char32_t*>(lua_State*&, const char32_t [2], const char32_t*)’ is ambiguous
 6919 |     return stack::push<const char32_t*>(L, str, str + sz);
In file included from osrm-backend/include/extractor/scripting_environment_lua.hpp:15,
                 from osrm-backend/src/extractor/scripting_environment_lua.cpp:1:
osrm-backend/third_party/sol2/sol2/sol.hpp:4600:14: note: candidate: ‘int sol::stack::push(lua_State*, T&&, Args&& ...) [with T = const char32_t*; Args = {const char32_t*}; lua_State = lua_State]’
 4600 |   inline int push(lua_State* L, T&& t, Args&&... args) {
osrm-backend/third_party/sol2/sol2/sol.hpp:4606:14: note: candidate: ‘int sol::stack::push(lua_State*, Arg&&, Args&& ...) [with T = const char32_t*; Arg = const char32_t (&)[2]; Args = {const char32_t*}; <template-parameter-1-4> = void; lua_State = lua_State]’
 4606 |   inline int push(lua_State* L, Arg&& arg, Args&&... args) {

Sol2 needs to be updated to at least 2.19.4

@systemed
Copy link
Member

Now that #5887 has landed (inter alia), can we close this?

@mloskot
Copy link
Member

mloskot commented Jan 29, 2021

@akashihi I'm closing this assuming it's been fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants