Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some data optional #5218

Open
danpat opened this issue Oct 2, 2018 · 3 comments
Open

Make some data optional #5218

danpat opened this issue Oct 2, 2018 · 3 comments

Comments

@danpat
Copy link
Member

danpat commented Oct 2, 2018

It'd be nice if you didn't need to load all the OSRM data if you didn't need it.

For example, if you never need turn-by-turn guidance, then it should be possible to skip the turn-by-turn data generation (save some time), and not bother loading it (save some memory). If you never need geometry (&geometries=false), then it shouldn't be required to load it.

Steps to getting this done are:

  1. Figure out which data structures various API parameters trigger traversal of (this could be done by looking at calls to the Datafacade interface)
  2. Make data loading optional for various only-used-sometimes data (including how to actually tell OSRM which data not to load).
  3. Modify datafacade interface to return a "data not loaded" error if a not-loaded is accessed
  4. Modify API interface to return a descriptive error if data isn't loaded

For a first version of this, we can limit it to not loading data into osrm-routed/node-osrm. As a second phase, we could possibly skip the creation of some data altogether (e.g. turn-by-turn data if it's not going to be used).

@danpat
Copy link
Member Author

danpat commented Oct 30, 2018

Note that with OSRM 5.20.0 using the --mmap option, you can sort of have this functionality - only pages of data that are used will be read into the filesystem cache, meaning you can run OSRM in limited memory environments.

This does not eliminate the data altogether and OSRM will still complain if it's missing, but you don't need all the RAM to get OSRM to even start.

Copy link

github-actions bot commented Jul 8, 2024

This issue seems to be stale. It will be closed in 30 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Jul 8, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 10, 2024
@jcoupey
Copy link

jcoupey commented Aug 20, 2024

Maybe others can comment here but this sounds like an interesting feature to keep track of.

@jcoupey jcoupey reopened this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants