Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows builds broken due to number formatting optimizations #5198

Closed
danpat opened this issue Sep 5, 2018 · 2 comments
Closed

Windows builds broken due to number formatting optimizations #5198

danpat opened this issue Sep 5, 2018 · 2 comments

Comments

@danpat
Copy link
Member

danpat commented Sep 5, 2018

This PR #5188 broke our Windows builds, because it depends on https://code.google.com/archive/p/msinttypes/, which I neglected to include.

We should third_party https://code.google.com/archive/p/msinttypes/, and add it to the include path on Windows
@PrefabPanda
Copy link

PrefabPanda commented Sep 13, 2018 •
edited
Loading

I've been having trouble building the source too, sadly my C++ knowledge is rather limited so I've gone with a revert on my local repo for this commit to hopefully see if it'll work!

@chaupow chaupow mentioned this issue Sep 27, 2018
Closed
6 tasks
@SiarheiFedartsou
Copy link
Member

Windows CI is green now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@SiarheiFedartsou @danpat @PrefabPanda