Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty name_id checks need to be changed to empty name_id string checks #4642

Closed
8 tasks done
MoKob opened this issue Oct 27, 2017 · 0 comments
Closed
8 tasks done

Empty name_id checks need to be changed to empty name_id string checks #4642

MoKob opened this issue Oct 27, 2017 · 0 comments

Comments

@MoKob
Copy link

MoKob commented Oct 27, 2017

The guidance engine relies on the use of name_id == EMPTY_NAMEID in many places where we decide between announcing/not announcing a turn. These checks interact with requiresNameAnnounced, which assumes turning onto a road without name doesn't require an announcement.
The checks for EMPTY_NAMEID precede the call of requiresNameAnnounced to ensure that roads without names are treated correctly.

With the addition of more and more fields to the field referenced to by name_id, a name_id != EMPTY_NAMEID can be true, even though the road doesn't have a name or a ref.

We need to revisit all checks that compare for EMPTY_NAMEID and ensure that they are working as intended when destination:ref (for example) is present on a road without name or ref.

Places to check:

  • src/engine/guidance/collapse_scenario_detection.cpp
  • src/extractor/extraction_containers.cpp (most likely fine)
  • src/extractor/guidance/intersection_handler.cpp
  • src/extractor/guidance/mergable_road_detector.cpp
  • src/extractor/guidance/motorway_handler.cpp
  • src/extractor/guidance/roundabout_handler.cpp
  • src/extractor/guidance/sliproad_handler.cpp
  • src/extractor/guidance/turn_handler.cpp
@karenzshea karenzshea changed the title name_id cannot be tested for Empty anymore Empty name_id checks need to be changed to empty name_id string checks Nov 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant