Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add restartability/continuation to osrm-extract #3651

Open
danpat opened this issue Feb 3, 2017 · 2 comments
Open

Add restartability/continuation to osrm-extract #3651

danpat opened this issue Feb 3, 2017 · 2 comments

Comments

@danpat
Copy link
Member

danpat commented Feb 3, 2017

The osrm-extract task takes a while, particularly on large datasets. When used in unreliable computing environments (i.e. market-priced cloud providers), it's not uncommon for long-running tasks to get interrupted.

osrm-extract can be modified to save its progress.

This line represents approximately the halfway processing point for osrm-extract.

Through an serendipitous accident of apathy/not-enough-time, osrm-extract could re-start processing at L245 if it happens to get killed after that for some reason.

/cc @miccolis

@daniel-j-h
Copy link
Member

Related: #2055

@TheMarex
Copy link
Member

TheMarex commented Mar 7, 2017

I don't think it makes sense to create checkpoints in the middle of a tool. This complicates the control flow, and breaks with expected behavior (basically the cache invalidation problem).

If we need a checkpoint we should split the tool into two parts with defined control flows.

In this specific example we could split it apart easily. But I suspect rewriting the initial OSM extraction code to be in-memory would probably make it unnecessary to do so, since we could exploit parallelism for all operations, rather then be IO bound. See #3767 for an actionable task for reducing the memory usage enough to make this feasible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants