You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
so for phantom input 1926039 weight is 1499 and speed is 3.61999.8/149.9=48.0272181454 -> 48,
but for phantom input 1926040 weight is 1500 and speed is 3.61999.8/150=47.9952 -> 47
so initial relative error of 2e-7 propagates to 1/48 in the result speed.
To fully fix these incompatibilities we need to switch from 1e6 to 1e7 coordinate precision. Since we expose the Coordinate objects to our users, that could be a breaking change, hence the 6.0 milestone.
Some tests expectation are ad hoc and have significant differences if input data is slightly translated, for example
fails in last row. The difference is due to rounding up in osmium at https://github.com/Project-OSRM/osrm-backend/blob/master/third_party/libosmium/include/osmium/osm/location.hpp#L183
but osrm uses truncated coordinates at https://github.com/Project-OSRM/osrm-backend/blob/master/include/util/coordinate.hpp#L77.
In the above test
so for phantom input 1926039 weight is 1499 and speed is 3.61999.8/149.9=48.0272181454 -> 48,
but for phantom input 1926040 weight is 1500 and speed is 3.61999.8/150=47.9952 -> 47
so initial relative error of 2e-7 propagates to 1/48 in the result speed.
Related issue #3354
The text was updated successfully, but these errors were encountered: