Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting conditional turn restrictions #2374

Closed
planemad opened this issue May 5, 2016 · 4 comments
Closed

Supporting conditional turn restrictions #2374

planemad opened this issue May 5, 2016 · 4 comments

Comments

@planemad
Copy link

planemad commented May 5, 2016

Previously: #583

The data team at Mapbox has been on a mapping sprint of missing turn restrictions from Mapillary and we have encountered over 100 of them in SF.

Many of the existing conditional restrictions are tagged like this:
screenshot 2016-05-05 15 19 26
wiki

There is no well defined tagging scheme for conditional turn restrictions, so the team is going to follow the conditional restriction format like this: restriction:conditional=no_left_turn @ (Mo-Fr 07:00-10:00,15:00-19:00) . Details.

Two questions:

  • Would be good to get some inputs if ^ is a good format for OSRM to use in the future?
  • When migrating old restrictions to this scheme, we add the restriction:conditional tag, but leave the original restriction tag unmodified. Will OSRM continue to treat these as a normal turn restriction?

cc @danpat @daniel-j-h @MoKob @oini

@danpat
Copy link
Member

danpat commented May 5, 2016

@planemad This change of tagging will affect OSRM. If restriction:conditional is seen on a relation, we'll skip the whole thing, the assumption being that its better to allow turns than restrict them most of the time (assuming conditions are only usually for short periods).

The current tagging scheme (as shown in your example) would mean that the restriction is always honoured. The change of tagging will mean that it's always ignored.

@planemad
Copy link
Author

planemad commented May 5, 2016

@danpat while updating the existing restrictions, the old tags are left intact. So the final version has both restriction and restriction:conditional like http://www.openstreetmap.org/relation/3792881 . To confirm, these will now be ignored as a turn restriction, yes?

Also any feedback on the tagging scheme itself. Given that there is no consensus on OSM on how to tag such features, it would be good to have an OSRM perspective of what would work best to implement this in future.

@danpat
Copy link
Member

danpat commented May 5, 2016

@planemad That's correct, the addition of the extra restriction:conditional tag will cause OSRM to skip the restriction entirely.

OSRM has no ability to support time-dependent features at all right now. As long as the syntax is well-structured and machine readable, that's probably all you need to do at the moment.

I just opened #2377 to discuss one (difficult) approach for possibly supporting this, but it's not going to be easy to implement, so won't happen any time soon.

@daniel-j-h
Copy link
Member

@oxidase is working on this in #3415.

Closing in favor of #3414.

cc @oxidase the scenarios outlined above are already great test cases! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants