Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Static Turn Instructions / Don't miss-use guidance #2114

Closed
10 tasks done
MoKob opened this issue Mar 18, 2016 · 1 comment
Closed
10 tasks done

Test Static Turn Instructions / Don't miss-use guidance #2114

MoKob opened this issue Mar 18, 2016 · 1 comment
Assignees
Milestone

Comments

@MoKob
Copy link

MoKob commented Mar 18, 2016

Breaking out from #2080

Since tests are currently requiring the infrastructure update to complete first (#2084), I am breaking these tests out of the original pull request to get a cleaner way of turn instructions into OSRM V5 early.

In general, the guidance tests should be the only ones using specific guidance results.
Other test should not rely on the actual instructions to be returned but focus on the ways/geometry or some other feature. Currently modifying guidance instructions can break all sorts of different tests, even though the tested feature is still intact.

  • add cucumber tests for static turn instructions
    • fork
    • end of road
    • new name
    • suppressed
    • continue
    • merge
    • ramp
    • roundabouts
  • find a way around the miss-use of turn instructions in other tests
@MoKob MoKob self-assigned this Mar 18, 2016
@MoKob MoKob added this to the 5.1.0 milestone Mar 18, 2016
@MoKob
Copy link
Author

MoKob commented Apr 4, 2016

#2133 implements all testes and removes instruction-types from other tests

@MoKob MoKob closed this as completed Apr 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant