Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return camel-case codes #2005

Closed
freenerd opened this issue Feb 23, 2016 · 4 comments
Closed

Return camel-case codes #2005

freenerd opened this issue Feb 23, 2016 · 4 comments
Assignees
Milestone

Comments

@freenerd
Copy link
Member

In develop the body of successful responses returns "code": "ok" but to stay in line with the documentation this should be camel-case "code": "Ok"

@freenerd freenerd changed the title Return calem-case Ok as code Return camel-case codes Feb 23, 2016
@freenerd freenerd added this to the 5.0 milestone Feb 23, 2016
@freenerd
Copy link
Member Author

Looks like codes generally aren't camel cased at the moment, e.g.

{ code: 'no-route', message: 'Impossible route between points' }

@emiltin
Copy link
Contributor

emiltin commented Feb 23, 2016

it might be a matter of style, but i prefer lowercase 'ok' and 'no-route'

@freenerd
Copy link
Member Author

@emiltin there is definitely no right or wrong answer here. the only weak argument i have is that 5 days ago we already discussed this and the new docs have camel case now.

@TheMarex
Copy link
Member

TheMarex commented Mar 9, 2016

Done.

@TheMarex TheMarex closed this as completed Mar 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants