Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latest commits seems to break a lot of tests? #145

Closed
emiltin opened this issue Feb 24, 2012 · 3 comments
Closed

latest commits seems to break a lot of tests? #145

emiltin opened this issue Feb 24, 2012 · 3 comments

Comments

@emiltin
Copy link
Contributor

emiltin commented Feb 24, 2012

it seems that the latest commits break a lot of cucumber tests, because no routes are returned.

for example, running "cucumber --tags @smallest" now fails for me:

=========================================
Failed scenario: A single way with two nodes
Time: 2012-02-24T14:02:26Z

<?xml version="1.0" encoding="UTF-8"?>
<osm generator="osrm-test" version="0.6">
  <node id="1" version="1" uid="1" user="osrm" timestamp="2000-00-00T00:00:00Z" lon="1.0" lat="1.0">
    <tag k="name" v="a"/>
  </node>
  <node id="2" version="1" uid="1" user="osrm" timestamp="2000-00-00T00:00:00Z" lon="1.000899199712256" lat="1.0">
    <tag k="name" v="b"/>
  </node>
  <way id="3" version="1" uid="1" user="osrm" timestamp="2000-00-00T00:00:00Z">
    <nd ref="1"/>
    <nd ref="2"/>
    <tag k="highway" v="primary"/>
    <tag k="name" v="ab"/>
  </way>
</osm>

[Scenario: A single way with two nodes]
accessTag = bicycle
defaultSpeed = 17
obeyOneways = yes
useRestrictions = yes
obeyBollards = no
cycleway = 19
primary = 19
primary_link = 19
secondary = 17
secondary_link = 17
tertiary = 15
residential = 15
unclassified = 15
living_street = 13
road = 13
service = 12
track = 12
path = 12
footway = 10
pedestrian = 5
pier = 5
steps = 3
ferry = 5
excludeFromGrid = ferry

Expected: {"from"=>"a", "to"=>"b", "route"=>"ab"}
Got: {"from"=>"a", "to"=>"b", "route"=>""}

Attempt: route
Query: http://localhost:5000/viaroute?start=1.0,1.0&dest=1.0,1.000899199712256&output=json&geomformat=cmp
Response: {"version": 0.3,"status":207,"status_message": "Cannot find route between points","route_summary": {"total_distance":0,"total_time":0,"start_point":"","end_point":""},"route_geometry": "","route_instructions": [],"via_points":[],"route_data": {"checksum":673387005, "hint_array": [-2, -2]},"transactionId": "OSRM Routing Engine JSON Descriptor (v0.3)"}

Expected: {"from"=>"b", "to"=>"a", "route"=>"ab"}
Got: {"from"=>"b", "to"=>"a", "route"=>""}

Attempt: route
Query: http://localhost:5000/viaroute?start=1.0,1.000899199712256&dest=1.0,1.0&output=json&geomformat=cmp
Response: {"version": 0.3,"status":207,"status_message": "Cannot find route between points","route_summary": {"total_distance":0,"total_time":0,"start_point":"","end_point":""},"route_geometry": "","route_instructions": [],"via_points":[],"route_data": {"checksum":673387005, "hint_array": [-2, -2]},"transactionId": "OSRM Routing Engine JSON Descriptor (v0.3)"}

@DennisOSRM
Copy link
Collaborator

Did you reprocess all data files or did you fetch them from cache. The commit contains some breaking changes.

@emiltin
Copy link
Contributor Author

emiltin commented Feb 24, 2012

deleting cache files and reprocessing indeed made tests pass. so my bad on this one.

cucumber is supposed to automatically reprocess data if the osrm binaries have changed, but apparently that must be broken - will look into it!

@emiltin emiltin closed this as completed Feb 24, 2012
@emiltin
Copy link
Contributor Author

emiltin commented Feb 24, 2012

fixed with #146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants