Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swish and mish activation functions #1235

Merged
merged 6 commits into from
Nov 16, 2020
Merged

swish and mish activation functions #1235

merged 6 commits into from
Nov 16, 2020

Conversation

rijobro
Copy link
Contributor

@rijobro rijobro commented Nov 16, 2020 •
edited
Loading

Description

Swish and Mish activation functions.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@rijobro rijobro requested review from ericspod, Nic-Ma and wyli and removed request for ericspod November 16, 2020 12:55
@rijobro
update examples
eaa303b 
Signed-off-by: Richard Brown <[email protected]>
wyli
wyli approved these changes Nov 16, 2020
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! could you please also update monai/networks/blocks/__init__.py with the new classes? and perhaps docs/source/networks.rst

@rijobro
Copy link
Contributor Author

rijobro commented Nov 16, 2020

@wyli done, thanks!

@wyli
Copy link
Contributor

wyli commented Nov 16, 2020

/integration-test
(testing the integration command)

@wyli wyli merged commit 8bbdc41 into Project-MONAI:master Nov 16, 2020
@drbeh
Copy link
Member

drbeh commented Nov 16, 2020

It seems that it the integration command works! Yay! But please let me know if you find any problem with that.

@rijobro rijobro deleted the activations branch November 17, 2020 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyli wyli wyli approved these changes

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

@ericspod ericspod Awaiting requested review from ericspod

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rijobro @wyli @drbeh