Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue when sampling the VQVAE+Transformer from 2d_vqvae_transformer_tutorial #320

Closed
Warvito opened this issue Mar 17, 2023 · 0 comments · Fixed by #322
Closed

Issue when sampling the VQVAE+Transformer from 2d_vqvae_transformer_tutorial #320

Warvito opened this issue Mar 17, 2023 · 0 comments · Fixed by #322
Assignees
@Warvito

Comments

@Warvito
Copy link
Collaborator

Warvito commented Mar 17, 2023

In 2d_vqvae_transformer_tutorial.ipy, I fixed the num_tokens in the training in #303 . But I missed the sampling code. In

GenerativeModels/tutorials/generative/2d_vqvae_transformer/2d_vqvae_transformer_tutorial.py

Line 367 in 6a9cc93

probs[:, vqvae_model.num_embeddings - 1] = 0

it should be
probs[:, vqvae_model.num_embeddings] = 0

@Warvito Warvito self-assigned this Mar 18, 2023
@Warvito Warvito mentioned this issue Mar 18, 2023
Merged
@Warvito Warvito linked a pull request Mar 18, 2023 that will close this issue
Fix generate function #322
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Warvito Warvito

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix generate function Project-MONAI/GenerativeModels
1 participant
@Warvito