Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix verbose type in inferer methods #259

Closed
Warvito opened this issue Feb 15, 2023 · 0 comments · Fixed by #264
Closed

Fix verbose type in inferer methods #259

Warvito opened this issue Feb 15, 2023 · 0 comments · Fixed by #264
Assignees
@marksgraham

Comments

@Warvito
Copy link
Collaborator

Warvito commented Feb 15, 2023

Currently, we are using verbose as bool | None types in some inferer methods, for example:

GenerativeModels/generative/inferers/inferer.py

Line 472 in 06a57bc

verbose: bool | None = True,

It might be better to just have it as bool since it will not have any different logic from verbose=False
@marksgraham marksgraham self-assigned this Feb 15, 2023
@marksgraham marksgraham mentioned this issue Feb 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marksgraham marksgraham

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes type Project-MONAI/GenerativeModels
2 participants
@Warvito @marksgraham