Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I think I find a error from page 520. #3

Open
sidgwick opened this issue Apr 10, 2018 · 1 comment
Open

I think I find a error from page 520. #3

sidgwick opened this issue Apr 10, 2018 · 1 comment

Comments

@sidgwick
Copy link

the code from P.520:

$( fields.insert($crate::ToString::to_string($key), json!($value)); )*

the code in this repository is:

$( fields.insert($crate::macros::ToString::to_string($key), json!($value)); )*

It should use the second version $crate::macros::ToString because ToString is private, just like HashMap?

😄

@jimblandy
Copy link
Contributor

CC @jorendorff

Thank you for reporting the problem!

The book and the example code do disagree, as he says.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants