A user cannot answer to a ticket by email if he has no default organization with the permission to create tickets

[marien-probesys]

Problem

We have a case where a user is only "invited" in an organization. This user cannot create tickets as he's not a customer. But he can answer to the tickets in which he's observer. When the user answers to a ticket by email, Bileto complains because "sender has not permission to create tickets".

How to reproduce

1. Create a role "invited user" with only the permission to answer to tickets
2. Create a user and grant him this role
3. Create a ticket and add this user as an observer
4. Verify that an email is sent to this user and answer to it with the address of the user
5. The email is rejected with the error "sender has not permission to create tickets"

What was expected?

The email should be accepted and the answer added to the ticket.

Solution

This is because of these lines: https://github.com/Probesys/bileto/blob/main/src/MessageHandler/CreateTicketsFromMailboxEmailsHandler.php#L125-L131

We shouldn't check if the user has an organization if he's answering to an existing ticket.

We must move the condition below:

if ($ticket) {
    // check if the user can answer to the ticket
} elseif ($requesterOrganization) {
    // create the ticket
} else {
    // mark the email in error and stop there
}