From 00951dcbe6be54abe8efd1c699e10de06595c274 Mon Sep 17 00:00:00 2001 From: Timon Klinkert <83671398+DenuxPlays@users.noreply.github.com> Date: Fri, 16 Aug 2024 13:45:23 +0200 Subject: [PATCH 1/3] Fixed acceptance test ci --- .github/workflows/ci.yml | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f338e79..a092311 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -34,6 +34,10 @@ jobs: acceptance-tests: name: Acceptance Tests runs-on: ubuntu-latest + # Set default working directory + defaults: + run: + working-directory: ./acceptance strategy: matrix: rust: [ "stable", "nightly" ] @@ -45,8 +49,10 @@ jobs: toolchain: ${{ matrix.rust }} - name: add cargo caching uses: Swatinem/rust-cache@v2 - - name: Run acceptance tests - run: cd acceptance && cargo test --verbose + - name: Run acceptance tests (build) + run: cargo build + - name: Run acceptance tests (tests) + run: cargo test --verbose format: name: Format From a5c0bd5ce30498ce71b97a99b495f8261bc406a1 Mon Sep 17 00:00:00 2001 From: Timon Klinkert <83671398+DenuxPlays@users.noreply.github.com> Date: Fri, 16 Aug 2024 13:49:40 +0200 Subject: [PATCH 2/3] Removed cargo caches It doesn't work across multiple pr. Somehow I get the cache from a non-related pr. This can cause the test to show false positives which we do not want! --- .github/workflows/ci.yml | 8 -------- 1 file changed, 8 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index a092311..5587c8b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -22,8 +22,6 @@ jobs: uses: dtolnay/rust-toolchain@master # Needed to always have access to the latest releases. DO NOT REPLACE WITH STABLE! with: toolchain: ${{ matrix.rust }} - - name: add cargo caching - uses: Swatinem/rust-cache@v2 - name: Build run: cargo build --all-features --verbose - name: Run tests @@ -47,8 +45,6 @@ jobs: uses: dtolnay/rust-toolchain@master # Needed to always have access to the latest releases. DO NOT REPLACE WITH STABLE! with: toolchain: ${{ matrix.rust }} - - name: add cargo caching - uses: Swatinem/rust-cache@v2 - name: Run acceptance tests (build) run: cargo build - name: Run acceptance tests (tests) @@ -63,8 +59,6 @@ jobs: uses: dtolnay/rust-toolchain@stable with: components: rustfmt - - name: add cargo caching - uses: Swatinem/rust-cache@v2 - name: run formater run: cargo fmt --check @@ -77,7 +71,5 @@ jobs: uses: dtolnay/rust-toolchain@stable with: components: clippy - - name: add cargo caching - uses: Swatinem/rust-cache@v2 - name: run formater run: cargo clippy -- -D warnings From a3bf04fd1aef355937f544049ccad2bf567fa6fd Mon Sep 17 00:00:00 2001 From: Timon Klinkert <83671398+DenuxPlays@users.noreply.github.com> Date: Fri, 16 Aug 2024 13:52:55 +0200 Subject: [PATCH 3/3] Nope cargo cache is fine Note to me: Learn how to read properly --- .github/workflows/ci.yml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 5587c8b..a092311 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -22,6 +22,8 @@ jobs: uses: dtolnay/rust-toolchain@master # Needed to always have access to the latest releases. DO NOT REPLACE WITH STABLE! with: toolchain: ${{ matrix.rust }} + - name: add cargo caching + uses: Swatinem/rust-cache@v2 - name: Build run: cargo build --all-features --verbose - name: Run tests @@ -45,6 +47,8 @@ jobs: uses: dtolnay/rust-toolchain@master # Needed to always have access to the latest releases. DO NOT REPLACE WITH STABLE! with: toolchain: ${{ matrix.rust }} + - name: add cargo caching + uses: Swatinem/rust-cache@v2 - name: Run acceptance tests (build) run: cargo build - name: Run acceptance tests (tests) @@ -59,6 +63,8 @@ jobs: uses: dtolnay/rust-toolchain@stable with: components: rustfmt + - name: add cargo caching + uses: Swatinem/rust-cache@v2 - name: run formater run: cargo fmt --check @@ -71,5 +77,7 @@ jobs: uses: dtolnay/rust-toolchain@stable with: components: clippy + - name: add cargo caching + uses: Swatinem/rust-cache@v2 - name: run formater run: cargo clippy -- -D warnings