Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to raw-loader v2 breaks style entry points #10

Closed
markusjwetzel opened this issue Mar 28, 2019 · 2 comments
Closed

Upgrade to raw-loader v2 breaks style entry points #10

markusjwetzel opened this issue Mar 28, 2019 · 2 comments
Labels

Comments

@markusjwetzel
Copy link
Contributor

If there is a *.scss file entry point in development, these styles will be injected via hot loading. While this is working with raw-loader v1, it is broken with raw-loader v2.

We need to find out why raw-loader v2 breaks style hot loading before we can upgrade to raw-loader v2!

@markusjwetzel
Copy link
Contributor Author

It might be related to the breaking change introduced in v2 that raw-loader uses ES module export instead of CommonJS now:
webpack-contrib/raw-loader#69

@markusjwetzel
Copy link
Contributor Author

Webpack 5 replaces raw-loader with asset/source:
https://webpack.js.org/guides/asset-modules/

Furthermore with the upgrade to webpack v5 this package no longer uses raw-loader at all, so this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant