Improve CI setup for per version tests #1267
Merged
+89
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rom1504
commented
Dec 25, 2023
•
rom1504
commented
- move lint out of per version
- bring packet cycle test back to per version
- generate versions to test from js file to avoid having versions in 2 places
|
not sure about this distinction between client / not client ; par / not par tests do you remember the point of this @u9g ? it's not even faster |
|
still not ready |
rom1504
changed the title
rom1504
changed the title
|
one additional thing I'd like to do here is make sure all the versions in version.js are mentioned in the readme besides that I think it's ready |
|
do you want to take a look @extremeheat ? |
extremeheat
reviewed
Dec 27, 2023
test/serverTest.js
Outdated
| @@ -94,7 +94,7 @@ for (const supportedVersion of mc.supportedVersions) { | |||
| } | |||
| } | |||
|
|
|||
| describe('mc-server ' + version.minecraftVersion, function () { | |||
| describe('mc-server ' + supportedVersion+'v', function () { | |||
There was a problem hiding this comment.
Lint isn't running on test/serverTest since the .gitignore has
test/server* instead of test/server_* in it https://github.com/PrismarineJS/node-minecraft-protocol/blob/improve_ci_setup/.gitignore#L3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.