Add minecraft:style to extraNodeData in command_node for 1.20.3/4 #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should fix an issue I say in our nmp / mineflayer 1.20.3/4 update work, that I had no idea how to fix. (I knew something was wrong in the delcare_command packet but had no idea due to how complex that thing is.) |
|
Thanks, didn't realise you opened a PR for this, this fixed was merged in #850 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
minecraft:styleat position 18 in the parser for extraNodeData in command_nodemoved everything onwards up by 1
this fixes the error generated on declare_command
PartialReadError: Read error for undefined : undefined