Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bedrock recipe text encoding issue #808

Merged
merged 2 commits into from
Dec 25, 2023

Conversation

extremeheat
Copy link
Member

Fix PrismarineJS/bedrock-protocol#469 (comment) where decode and re-encode yeilds different data, but only applying this to recipe IDs

Reading strings as latin1/ascii prevents issues with UTF-8 where byte length != char length as there are no multibyte characters

@rom1504 rom1504 merged commit 900ebf2 into PrismarineJS:master Dec 25, 2023
4 checks passed
@rom1504
Copy link
Member

rom1504 commented Dec 25, 2023

/makerelease

@rom1504bot rom1504bot mentioned this pull request Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with Recipes on a relay.
2 participants