Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1.20.3 and 1.20.4 extract-able data #803

Merged
merged 6 commits into from
Dec 17, 2023
Merged

Conversation

wgaylord
Copy link
Contributor

@wgaylord wgaylord commented Dec 13, 2023

This adds all the extract-able data for 1.20.3 and 1.20.4

Interestingly there were changes to the block.json between 1.20.3 and 1.20.4.

Also due to how the newer "experimental" features stuff works I have noticed that the block data includes the 1.21 blocks that are exposed by that experimental switch on world creation.

The protocol for 1.20.3 and 1.20.4 are currently pointing at 1.20.2, this won't work due to changes in chat messages (Now NBT data instead of JSON) and new packets in the configuration and play states. (Relating to resourcepacks)

@wgaylord
Copy link
Contributor Author

We should hold off on merging this till #804 gets figured out since I used the same to generate this data

@rom1504
Copy link
Member

rom1504 commented Dec 17, 2023

what tools did you use for generation ?

@wgaylord
Copy link
Contributor Author

I used https://github.com/PrismarineJS/minecraft-data-generator-server

I also have a version that includes the mapicon.json generation as well.

@rom1504
Copy link
Member

rom1504 commented Dec 17, 2023

is this ready to merge now ? looks fine to me

@rom1504
Copy link
Member

rom1504 commented Dec 17, 2023

ah please add the versions in the readme

@wgaylord
Copy link
Contributor Author

I will add the versions in the readme. Also this currently does not have a protocol.json for 1.20.3/1.20.4 yet as noted in the initial PR message. I will be making another PR for that to full explain the changes that occured.

@rom1504 rom1504 merged commit b108872 into PrismarineJS:master Dec 17, 2023
4 checks passed
@rom1504
Copy link
Member

rom1504 commented Dec 17, 2023

thanks

@rom1504
Copy link
Member

rom1504 commented Dec 17, 2023

we'll need the protocol next indeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

2 participants