Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review and fix protocol.json for 1.20.2 #788

Closed
rom1504 opened this issue Nov 5, 2023 · 5 comments
Closed

Review and fix protocol.json for 1.20.2 #788

rom1504 opened this issue Nov 5, 2023 · 5 comments

Comments

@rom1504
Copy link
Member

rom1504 commented Nov 5, 2023

See https://github.com/PrismarineJS/minecraft-data/blob/master/data/pc/1.20.2/protocol.json
@rom1504 rom1504 pinned this issue Nov 5, 2023
@rom1504
Copy link
Member Author

rom1504 commented Nov 5, 2023

#786 introduced there

@rom1504
Copy link
Member Author

rom1504 commented Nov 5, 2023

We need a description of what was changed there. Ideally with pointers to some reference.
Ideally with step by step commits introducing one change at a time

@wgaylord
Copy link
Contributor

wgaylord commented Nov 5, 2023

https://gist.github.com/wgaylord/e1196e832bf5e385b00c85c767de0d40

All of this was based on wiki.vg. https://wiki.vg/index.php?title=Pre-release_protocol&oldid=18386 is also a good source as the last diff between 1.20.2 and 1.20.1 on it.

@extremeheat
Copy link
Member

1.20.1 and 1.20.2 diff at https://github.dev/extremeheat/extracted_minecraft_data/pull/5

@extremeheat
Copy link
Member

done in #812

@rom1504 rom1504 unpinned this issue Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wgaylord @rom1504 @extremeheat