New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Food data extractor generates bad data #39

Open

extremeheat opened this issue Nov 26, 2024 · 1 comment · May be fixed by #40

Member

extremeheat commented Nov 26, 2024

1.21 - https://github.com/PrismarineJS/minecraft-data-generator/blob/main/mc/1.21/src/main/java/dev/u9g/minecraftdatagenerator/generators/FoodsDataGenerator.java
1.20.5 - https://github.com/PrismarineJS/minecraft-data-generator/blob/main/mc/1.20.5/src/main/java/dev/u9g/minecraftdatagenerator/generators/FoodsDataGenerator.java

generates data on the right, correct is data on the left

via https://discord.com/channels/413438066984747026/743199746876768318/1310826677554778120

relevant minecraft code: https://github.com/extremeheat/extracted_minecraft_data/blob/client1.21.3/client/net/minecraft/world/food/Foods.java

Any idea what's happening here @AlexProgrammerDE ? saturationRatio seems to be incorrect, and that will break the other fields. There is a script to extract from the source code here - https://github.com/PrismarineJS/minecraft-data/blob/master/tools/js/extractPcFoods.js

The text was updated successfully, but these errors were encountered:

Collaborator

AlexProgrammerDE commented Nov 26, 2024 •

edited

Loading

Seems like the meaning of the value shifted a little then. Will check what mc uses internally when home.

SuperGamerTron linked a pull request

that will close this issue

Fix FoodsDataGenerator for 1.20.5+ #40

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment