Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WPF] Immutable IoC #1579

Closed
Karnah opened this issue Oct 16, 2018 · 3 comments
Closed

[WPF] Immutable IoC #1579

Karnah opened this issue Oct 16, 2018 · 3 comments

Comments

@Karnah
Copy link

Karnah commented Oct 16, 2018

Good day! Could you explain why you've created this commit (link)?
We implement own PrismApplication based on LightInject which doesn't support modules. And after version 7.1.0.431 InitializeModules throws NotSupportedException.
I've overrided InitializeModules method with empty body, but it's a bit weird.

@Karnah Karnah changed the title Immutable IoC [WPF] Immutable IoC Oct 16, 2018
@brianlagunas
Copy link
Member

Immutable containers do not work with modularity which is a core function in Prism. If you want to use an immutable container, you must be aware of what functionality you are loosing, and this does the job. SO y have a choice, you can return true for SupportsModules in your custom implementation and not use them, or do what you have already done and override the InitializeModules method. Either way, you know that modularity is not supported with your container.

@Karnah
Copy link
Author

Karnah commented Oct 16, 2018

Ok, thanks for reply!

@lock
Copy link

lock bot commented Jan 29, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants