-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Language Nevod #2798
Language Nevod #2798
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR @dmitry-surkov!
I left you a few comments but we also need to talk about punctuation and operators. Right now, you defined a lot of patterns. The problem with that is that our themes do not recognize these token names, leaving them unhighlighted. On your website, you solved this by modifying your themes but this a lot harder on our side.
Would it be possible to combine these patterns into an operator
and a punctuation
token like we do in other languages? If more granular highlighting is needed, I suggest doing it like this:
{
'operator': [
{
pattern: /=/,
alias: 'equals'
},
// rest
/[-+*/]/
]
}
0247dfa
to
784ad01
Compare
Co-authored-by: Michael Schmidt <[email protected]>
Co-authored-by: Michael Schmidt <[email protected]>
c776878
to
66037d9
Compare
@RunDevelopment, seems I have resolved all the issues. Do you see any other issues that prevent this PR from merge? Btw, I have also merged all changes from the |
Thank you for contributing @dmitry-surkov! |
Add support for Nevod language used for pattern-based text search.