-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PromQL language support #2628
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR @arendjr!
I gave your PR a quick look and left you some comments. I'll give it a more in-depth review later.
Additional notes:
Thanks for the thorough feedback already! I have addressed the styling issues, split keywords and functions as appropriate, simplified some things and added another comment to address one of your questions :) To be honest, I'm not sure about all the original motivations, as I reused some code from the Monaco highlighter and the blog post I referenced, but thanks to your review, I think it's pretty cleaned up now. |
Thank you for the quick response! I still have some minor nits but it's overall it looks really good now. |
Co-authored-by: Michael Schmidt <[email protected]>
Co-authored-by: Michael Schmidt <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebuild, so I can merge.
Done! |
Thank you for contributing @arendjr! |
Thanks for your support! 🚀 |
This PR adds support for PromQL: https://prometheus.io/docs/prometheus/latest/querying/examples/